Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22594 Fix likelysubtags for macroregion 001 and 150 #2725

Closed
wants to merge 1 commit into from
Closed

ICU-22594 Fix likelysubtags for macroregion 001 and 150 #2725

wants to merge 1 commit into from

Conversation

FrankYFTang
Copy link
Contributor

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22594
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@FrankYFTang FrankYFTang requested review from sffc, markusicu and macchiati and removed request for markusicu December 5, 2023 23:38
macchiati
macchiati requested changes Dec 6, 2023
View reviewed changes
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was asking for what ICU did, not to make a change. As @sffc says, we're considering disabling the macroregion mapping, and we don't want to flip-flop.

@FrankYFTang
Copy link
Contributor Author

ok, I see. I missed that part.

@FrankYFTang FrankYFTang closed this Dec 6, 2023
@FrankYFTang FrankYFTang deleted the ICU-22594-likelysubtags branch March 19, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macchiati macchiati macchiati requested changes

@sffc sffc Awaiting requested review from sffc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankYFTang @macchiati